Update protos with Tensorflow data validation schema #438
Conversation
These are copied from definition in Schema.proto in tensorflow data validation
davidheryanto
requested review from
khorshuheng,
pradithya,
woop and
zhilingc
as code owners
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidheryanto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
I think I've just learned of the Feature Validation RFC, perhaps it could be referenced in the PR description. Although I believe it's only currently accessible to feast-dev—I was wondering if there's a plan to make these publicly readable, when I just found that making this one public was an action item from a December community call 😇 I've taken the liberty to add an agenda point for next call about making these available for feedback earlier. |
Damn we messed up again. Feel free to add comments to the document. We're planning to keep fleshing things out over in the RFC. |
What this PR does / why we need it:
This pull request is regarding feature validation in Feast. It updates
EntitySpecandFeatureSpecprotos with fields to specify constaints for the values. The constraint specs are adapted from Tensorflow metadata schema: https://github.com/tensorflow/metadata/blob/3b9d4114c6856ce18b7819023acb94f07183d348/tensorflow_metadata/proto/v0/schema.proto.Only
presence_constraints,shape_typeanddomain_infoare currently added toEntitySpecandFeatureSpecbecause it is adequate for the current validation requirement in Feast and to ensure integration with Tensorflow data validation works correctly, before adding more features supported in Tensorflow validation.Which issue(s) this PR fixes:
Partially addresses #172
Does this PR introduce a user-facing change?:
No, user-facing change with updates in Feast SDK will follow in subsequent pull requests.